Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove References to Params Module [SDK v50] #798

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: remove References to Params Module [SDK v50] #798

wants to merge 1 commit into from

Conversation

joelsmith-2019
Copy link
Contributor

Close #792

These changes remove the references to the deprecated Params module.

@Reecepbcups Reecepbcups added the blocked We can't do this until something else is done label Sep 19, 2023
@Reecepbcups
Copy link
Contributor

Reecepbcups commented Oct 10, 2023 •
edited
Loading

I am going to do the PFM / ICQ migrations this week (or next) for v18 to get off params

@Reecepbcups Reecepbcups removed the blocked We can't do this until something else is done label Nov 6, 2023
@Reecepbcups
Copy link
Contributor

Reecepbcups commented Nov 6, 2023 •
edited
Loading

This is no longer blocked

Should use mainline tags v7.1.1

@Reecepbcups Reecepbcups changed the title chore: Remove References to Params Module chore: v19 remove References to Params Module Nov 6, 2023
@Reecepbcups Reecepbcups changed the title chore: v19 remove References to Params Module chore: remove References to Params Module [SDK v50] Nov 9, 2023
@Reecepbcups
Copy link
Contributor

Reecepbcups commented Nov 9, 2023 •
edited
Loading

Blocked on SDK v50 with IBC-Go v8 migrations

@joelsmith-2019 joelsmith-2019 added the blocked We can't do this until something else is done label Nov 10, 2023
@faddat
Copy link
Contributor

faddat commented Feb 10, 2024

indeed back then ibc-apps was a blocker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeHartnell JakeHartnell Awaiting requested review from JakeHartnell JakeHartnell will be requested when the pull request is marked ready for review JakeHartnell is a code owner

@dimiandre dimiandre Awaiting requested review from dimiandre dimiandre will be requested when the pull request is marked ready for review dimiandre is a code owner

@niilptr niilptr Awaiting requested review from niilptr niilptr will be requested when the pull request is marked ready for review niilptr is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@joelsmith-2019 joelsmith-2019

Labels
blocked We can't do this until something else is done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: Remove x/params module
3 participants
@joelsmith-2019 @Reecepbcups @faddat